Solr
  1. Solr
  2. SOLR-1242

The admin System handler returns bad JVM info

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.4
    • Component/s: None
    • Labels:
      None

      Description

      FileUtils.byteCountToDisplaySize has a funny way of converting.

      runtime.maxMemory() : 2092236800 bytes
      commons-io display : 1 GB

      Appears to be more than just a rounddown, because it will knock over 3 gig to 2 gig as well. Odd stuff.

      1. SOLR-1242.patch
        3 kB
        Mark Miller
      2. SOLR-1242.patch
        3 kB
        Mark Miller

        Activity

        Hide
        Mark Miller added a comment -

        Reported by Jay Hill.

        Show
        Mark Miller added a comment - Reported by Jay Hill.
        Hide
        Mark Miller added a comment -

        Nevermind. It is a round down issue. A bit over 3 gig in bytes just works out to round down to 2gig I guess.

        Anyway, when dealing with gb, just dropping the remainder (no round up) is not good. Rounding in general is not great. Gimme at least one decimal point

        I'll work up a patch.

        Show
        Mark Miller added a comment - Nevermind. It is a round down issue. A bit over 3 gig in bytes just works out to round down to 2gig I guess. Anyway, when dealing with gb, just dropping the remainder (no round up) is not good. Rounding in general is not great. Gimme at least one decimal point I'll work up a patch.
        Hide
        Mark Miller added a comment - - edited

        Here we go - much better...rounds to one decimal rather than int (only round down cutoff) rounding.

        Show
        Mark Miller added a comment - - edited Here we go - much better...rounds to one decimal rather than int (only round down cutoff) rounding.
        Hide
        Mark Miller added a comment -

        tweak names

        Show
        Mark Miller added a comment - tweak names
        Hide
        Mark Miller added a comment -

        Committed. Thanks Jay!

        Show
        Mark Miller added a comment - Committed. Thanks Jay!
        Hide
        Grant Ingersoll added a comment -

        Bulk close for Solr 1.4

        Show
        Grant Ingersoll added a comment - Bulk close for Solr 1.4

          People

          • Assignee:
            Mark Miller
            Reporter:
            Mark Miller
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development