Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-12188

Inconsistent behavior with CREATE collection API

Details

    • Bug
    • Status: Patch Available
    • Major
    • Resolution: Unresolved
    • 7.4
    • None
    • Admin UI, config-api
    • None

    Description

      If collection.configName is not specified during create collection then _default configSet is used to create mutable configSet (with suffix AUTOCREATED)

      • In the Admin UI, it is mandatory to specify configSet. This behavior is inconsistent with CREATE collection API(where it is not mandatory)
      • Both in Admin UI and CREATE API, when _default is specified as configSet then no mutable configSet is created. So, changes in one collection would reflect in other

      Attachments

        1. SOLR-12188.patch
          1 kB
          Munendra S N

        Activity

          munendrasn Munendra S N added a comment -

          SOLR-12188.patch
          With this patch, CREATE collection in Admin UI would mimic CREATE API behavior i.e, if configSet is not passed then mutable configSet with suffix .AUTOCREATED would be created.

          But when _default is specified as configSet then no new mutable configSet is not created. In this case, collections would share the _default configSet. Should this also be changed?

          munendrasn Munendra S N added a comment - SOLR-12188.patch With this patch, CREATE collection in Admin UI would mimic CREATE API behavior i.e, if configSet is not passed then mutable configSet with suffix .AUTOCREATED would be created. But when _default is specified as configSet then no new mutable configSet is not created. In this case, collections would share the _default configSet. Should this also be changed?
          lucenesolrqa Lucene/Solr QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
                Prechecks
                master Compile Tests
                Patch Compile Tests
          +1 Validate source patterns 0m 3s the patch passed
                Other Tests
          0m 47s



          Subsystem Report/Notes
          JIRA Issue SOLR-12188
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12917712/SOLR-12188.patch
          Optional Tests validatesourcepatterns
          uname Linux lucene1-us-west 3.13.0-88-generic #135-Ubuntu SMP Wed Jun 8 21:10:42 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool ant
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
          git revision master / d2ac323
          ant version: Apache Ant(TM) version 1.9.3 compiled on April 8 2014
          modules C: solr/webapp U: solr/webapp
          Console output https://builds.apache.org/job/PreCommit-SOLR-Build/135/console
          Powered by Apache Yetus 0.7.0 http://yetus.apache.org

          This message was automatically generated.

          lucenesolrqa Lucene/Solr QA added a comment - +1 overall Vote Subsystem Runtime Comment       Prechecks       master Compile Tests       Patch Compile Tests +1 Validate source patterns 0m 3s the patch passed       Other Tests 0m 47s Subsystem Report/Notes JIRA Issue SOLR-12188 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12917712/SOLR-12188.patch Optional Tests validatesourcepatterns uname Linux lucene1-us-west 3.13.0-88-generic #135-Ubuntu SMP Wed Jun 8 21:10:42 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool ant Personality /home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh git revision master / d2ac323 ant version: Apache Ant(TM) version 1.9.3 compiled on April 8 2014 modules C: solr/webapp U: solr/webapp Console output https://builds.apache.org/job/PreCommit-SOLR-Build/135/console Powered by Apache Yetus 0.7.0 http://yetus.apache.org This message was automatically generated.

          I think we should move "configSet" box to the advanced section. A regular user (non advanced user) doesn't need to specify a configSet.

          ichattopadhyaya Ishan Chattopadhyaya added a comment - I think we should move "configSet" box to the advanced section. A regular user (non advanced user) doesn't need to specify a configSet.
          erickerickson Erick Erickson added a comment -

          The default configset is trappy enough since it defaults to schemaless, I kind of like that it is in people's faces. I agree it's inconsistent, but am happy to live with that. I wouldn't veto the change, but wanted to mention it....

          erickerickson Erick Erickson added a comment - The default configset is trappy enough since it defaults to schemaless, I kind of like that it is in people's faces. I agree it's inconsistent, but am happy to live with that. I wouldn't veto the change, but wanted to mention it....
          lucenesolrqa Lucene/Solr QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
                Prechecks
                master Compile Tests
                Patch Compile Tests
          +1 Validate source patterns 0m 3s the patch passed
                Other Tests
          0m 26s



          Subsystem Report/Notes
          JIRA Issue SOLR-12188
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12917712/SOLR-12188.patch
          Optional Tests validatesourcepatterns
          uname Linux lucene2-us-west.apache.org 4.4.0-112-generic #135-Ubuntu SMP Fri Jan 19 11:48:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
          Build tool ant
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
          git revision master / 33c9456
          ant version: Apache Ant(TM) version 1.9.6 compiled on July 20 2018
          modules C: solr/webapp U: solr/webapp
          Console output https://builds.apache.org/job/PreCommit-SOLR-Build/384/console
          Powered by Apache Yetus 0.7.0 http://yetus.apache.org

          This message was automatically generated.

          lucenesolrqa Lucene/Solr QA added a comment - +1 overall Vote Subsystem Runtime Comment       Prechecks       master Compile Tests       Patch Compile Tests +1 Validate source patterns 0m 3s the patch passed       Other Tests 0m 26s Subsystem Report/Notes JIRA Issue SOLR-12188 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12917712/SOLR-12188.patch Optional Tests validatesourcepatterns uname Linux lucene2-us-west.apache.org 4.4.0-112-generic #135-Ubuntu SMP Fri Jan 19 11:48:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux Build tool ant Personality /home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh git revision master / 33c9456 ant version: Apache Ant(TM) version 1.9.6 compiled on July 20 2018 modules C: solr/webapp U: solr/webapp Console output https://builds.apache.org/job/PreCommit-SOLR-Build/384/console Powered by Apache Yetus 0.7.0 http://yetus.apache.org This message was automatically generated.

          The default configset is trappy enough since it defaults to schemaless, I kind of like that it is in people's faces. I agree it's inconsistent, but am happy to live with that. I wouldn't veto the change, but wanted to mention it....

          The intent of the move to make configset optional was to ensure that it stays out of users' way as an internal detail. However, since it defaults to schemaless, how about we add a warning (popup) at the time of creation that this shouldn't be used for production because schemaless is not recommended (similar to what the API warns)?

          ichattopadhyaya Ishan Chattopadhyaya added a comment - The default configset is trappy enough since it defaults to schemaless, I kind of like that it is in people's faces. I agree it's inconsistent, but am happy to live with that. I wouldn't veto the change, but wanted to mention it.... The intent of the move to make configset optional was to ensure that it stays out of users' way as an internal detail. However, since it defaults to schemaless, how about we add a warning (popup) at the time of creation that this shouldn't be used for production because schemaless is not recommended (similar to what the API warns)?

          People

            ichattopadhyaya Ishan Chattopadhyaya
            munendrasn Munendra S N
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated: