[SOLR-12083] RealTimeGetComponent fails for INPLACE_UPDATE when Cdcr enabled

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 7.2, 7.2.1
• Fix Version/s: 7.3
• Component/s: CDCR
• Assignee: Varun Thacker
• Reporter: Amrit Sarkar
• Created: 13/Mar/18 01:07
• Updated: 21/Nov/19 00:42
• Resolved: 18/Mar/18 18:44

Description

When we were adding bi-directional sync support in CDCR ( SOLR-11003 ) we changed the CDCR Update Log codec to write an extra bits. 

When we use the RealTimeGet component on a cluster running CDCR and have in-place updates in the update log we will falsely trip an assert thus causing the request to fail

Here's the proposed change

-                 assert entry.size() == 5;
+                 if (ulog instanceof CdcrUpdateLog) {
+                   assert entry.size() == 6;
+                 }
+                 else {
+                   assert entry.size() == 5;
+                 }