Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-11977

QEC editorialMarkerFieldName & excludeMarkerFieldName are confusing and silly

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      QueryElevationComponent suppports 2 initParams that are weird and very inconsistent with how similar features in solr work...

      • editorialMarkerFieldName
      • excludeMarkerFieldName

      These init params simply provide an "override" to the names "elevated" and "excluded" that are used in QueryElevationComponent.inform(SolrCore) to change the names used when registering instances of EditorialMarkerFactory and ExcludedMarkerFactory as DocTransformers.

      This makes no sense – we already have a standard mechanism for people to override the default names used by doc transformers.

      We should:

      1. deprecated & remove & undocument these options and remove the relvant code from QEC
      2. add these transformers to TransformerFactory.defaultFactories using their default names

      ... users that have a strong desire to override these names should do so by explicitly registering them as <transformer name="..." just like an other DocTransformer.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              hossman Chris M. Hostetter
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated: