[SOLR-11868] Deprecate CloudSolrClient.setIdField, use information from Zookeeper

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 7.2
• Fix Version/s: 8.7
• Assignee: Erick Erickson
• Reporter: Erick Erickson
• Created: 17/Jan/18 22:47
• Updated: 01/Mar/21 17:05
• Resolved: 26/Jul/20 23:23

Description

IIUC idField has nothing to do with the <uniqueKey> field. It's really
the field used to route documents. Agreed, this is often the "id"
field, but still....

In fact, over in UpdateReqeust.getRoutes(), it's passed as the "id"
field to router.getTargetSlice() and just works, even though
getTargetSlice is clearly designed to route on a field other than the
<uniqueKey> if we didn't just pass null as the "route" param.

The confusing bit is that if I have a route field defined for my
collection and want to use CloudSolrClient I have to figure out that I
need to use the setIdField method to use that field for routing.

 

We should deprecate setIdField and refactor how this is used (i.e. getRoutes). Need to beef up tests too I suspect.

Issue Links

• is related to: SOLR-11983 No indication in CloudSolrClient for missing id field
• is related to: SOLR-7384 Delete-by-id with _route_ parameter fails on replicas for collections with implicit router
• is related to: SOLR-8889 SolrCloud deleteById is broken when router.field is set
• relates to: SOLR-10465 setIdField should be deprecated in favor of SolrClientBuilder methods
• relates to: SOLR-15205 don't mention (deprecated) CloudSolrClient.setIdField in javadocs