Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-11758

Missing boolVal implementation in FloatDocValues

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 7.3, 8.0
    • None
    • None

    Description

      In case of DoubleDocValues, boolVal(int doc) has been implemented but this is missing in case FloatDocValues.

      Impact: For any DocValues which extends FloatDocValues and doesn't implement boolVal(int doc), parent boolVal in FucntionValues would be called.

      boolVal implementation in FunctionValues

        @Override
        public boolean boolVal(int doc) throws IOException {
          return intVal(doc) != 0;
        }
      

      Let me know if I can work on it

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            hossman Chris M. Hostetter
            munendrasn Munendra S N
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - 2h
                2h
                Remaining:
                Remaining Estimate - 2h
                2h
                Logged:
                Time Spent - Not Specified
                Not Specified

                Slack

                  Issue deployment