[SOLR-11551] Standardize response codes and success/failure determination for core-admin api calls

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 7.4, 8.0
• Assignee: Jason Gerlowski
• Reporter: Varun Thacker
• Created: 25/Oct/17 20:05
• Updated: 21/Nov/19 00:41
• Resolved: 24/Mar/18 16:41

Description

If we were to tackle SOLR-11526 I think we need to start fixing the core admin api's first.

If we are relying on response codes I think we should make the following change and fix all the APIs

  interface CoreAdminOp {
    void execute(CallInfo it) throws Exception;
  }

To

  interface CoreAdminOp {
    /**
     *
     * @param it request/response object
     *
     * If the request is invalid throw a SolrException with SolrException.ErrorCode.BAD_REQUEST ( 400 )
     * If the execution of the command fails throw a SolrException with SolrException.ErrorCode.SERVER_ERROR ( 500 )
     * Add a "error-message" key to the response object with the exception ( this part should be done at the caller of this method so that each operation doesn't need to do the same thing )
     */
    void execute(CallInfo it);
  }

cc gerlowskija

Issue Links

• is duplicated by: SOLR-5180 Core admin reload for an invalid core name returns 500 rather than 400 status code
• relates to: SOLR-11631 Schema API always has status 0