[SOLR-11444] Improve Aliases.java and comma delimited collection list handling

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 7.2
• Component/s: SolrCloud
• Assignee: David Smiley
• Reporter: David Smiley
• Created: 06/Oct/17 16:27
• Updated: 08/Oct/19 14:51
• Resolved: 19/Oct/17 04:06

Description

While starting to look at SOLR-11299 I noticed some brittleness in assumptions about Strings that refer to a collection. Sometimes they are in fact references to comma separated lists, which appears was added with the introduction of collection aliases (an alias can refer to a comma delimited list). So Java's type system kind of goes out the window when we do this. In one case this leads to a bug – CloudSolrClient will throw an NPE if you try to write to such an alias. Sending an update via HTTP will allow it and send it to the first in the list.

So this issue is about refactoring and some little improvements pertaining to Aliases.java plus certain key spots that deal with collection references. I don't think I want to go as far as changing the public SolrJ API except to adding documentation on what's possible.

Issue Links

• contains: SOLR-10181 CREATEALIAS and DELETEALIAS commands consistency problems under concurrency
• is depended upon by: SOLR-11488 Do not allow collections and aliases to have the same name
• is part of: SOLR-11299 Time partitioned collections (umbrella issue)
• is related to: SOLR-11218 Fail and return an error when attempting to delete a collection that's part of an alias
• relates to: SOLR-11292 Querying against an alias can lead to incorrect routing
• relates to: SOLR-10181 CREATEALIAS and DELETEALIAS commands consistency problems under concurrency