Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-11444

Improve Aliases.java and comma delimited collection list handling

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 7.2
    • Component/s: SolrCloud
    • Labels:
      None

      Description

      While starting to look at SOLR-11299 I noticed some brittleness in assumptions about Strings that refer to a collection. Sometimes they are in fact references to comma separated lists, which appears was added with the introduction of collection aliases (an alias can refer to a comma delimited list). So Java's type system kind of goes out the window when we do this. In one case this leads to a bug – CloudSolrClient will throw an NPE if you try to write to such an alias. Sending an update via HTTP will allow it and send it to the first in the list.

      So this issue is about refactoring and some little improvements pertaining to Aliases.java plus certain key spots that deal with collection references. I don't think I want to go as far as changing the public SolrJ API except to adding documentation on what's possible.

        Attachments

        1. SOLR-11444.patch
          86 kB
          Erick Erickson
        2. SOLR-11444.patch
          93 kB
          David Smiley
        3. SOLR_11444_Aliases.patch
          60 kB
          David Smiley
        4. SOLR_11444_Aliases.patch
          83 kB
          David Smiley

          Issue Links

            Activity

              People

              • Assignee:
                dsmiley David Smiley
                Reporter:
                dsmiley David Smiley
              • Votes:
                0 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: