Details

    • Type: Improvement
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 6.6
    • Fix Version/s: 6.6.1, 6.7, 7.0, 7.1, master (8.0)
    • Component/s: Hadoop Integration, hdfs
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None

      Description

      In SOLR-10966 we added a "bad" workaround to prevent Hadoop's Shell class from breaking with Java 9 (StringIndexOutOfBoundsException). This was resolved in Hadoop 2.7.4, released a few weeks ago. We should revert the bad hack and update Hadoop.

      After running tests, I see no issue with the bugfix relaese.

      I will commit to master and 7.x and once it settled, I will backport. If we can't get this into 6.6.1, it's not so bad, but then we have to live with the "bad" hack there.

      1. SOLR-11261.patch
        12 kB
        Uwe Schindler
      2. SOLR-11261-2.patch
        3 kB
        Uwe Schindler

        Issue Links

          Activity

          Hide
          thetaphi Uwe Schindler added a comment -

          Here is the patch. It's just a revert of the superceeded issue and raising version number.

          Show
          thetaphi Uwe Schindler added a comment - Here is the patch. It's just a revert of the superceeded issue and raising version number.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit c68e668dd7b2522f1f6c7785f256882f0fd8875d in lucene-solr's branch refs/heads/master from Uwe Schindler
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c68e668 ]

          SOLR-11261, SOLR-10966: Upgrade to Hadoop 2.7.4 to fix incompatibility with Java 9.
          This also reverts commit 85a27a231fdddb118ee178baac170da0097a02c0.

          Show
          jira-bot ASF subversion and git services added a comment - Commit c68e668dd7b2522f1f6c7785f256882f0fd8875d in lucene-solr's branch refs/heads/master from Uwe Schindler [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c68e668 ] SOLR-11261 , SOLR-10966 : Upgrade to Hadoop 2.7.4 to fix incompatibility with Java 9. This also reverts commit 85a27a231fdddb118ee178baac170da0097a02c0.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit dfd42bf8c9dfbafb5f68e644b217acf9981d6555 in lucene-solr's branch refs/heads/branch_7x from Uwe Schindler
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=dfd42bf ]

          SOLR-11261, SOLR-10966: Upgrade to Hadoop 2.7.4 to fix incompatibility with Java 9.
          This also reverts commit 85a27a231fdddb118ee178baac170da0097a02c0.

          Show
          jira-bot ASF subversion and git services added a comment - Commit dfd42bf8c9dfbafb5f68e644b217acf9981d6555 in lucene-solr's branch refs/heads/branch_7x from Uwe Schindler [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=dfd42bf ] SOLR-11261 , SOLR-10966 : Upgrade to Hadoop 2.7.4 to fix incompatibility with Java 9. This also reverts commit 85a27a231fdddb118ee178baac170da0097a02c0.
          Hide
          thetaphi Uwe Schindler added a comment -

          I committed to master and branch_7x as a first step. If Jenkins is happy, I will backport to the following branches later:

          • branch_7_0
          • branch_6x
          • branch_6_6
          Show
          thetaphi Uwe Schindler added a comment - I committed to master and branch_7x as a first step. If Jenkins is happy, I will backport to the following branches later: branch_7_0 branch_6x branch_6_6
          Hide
          thetaphi Uwe Schindler added a comment -

          Unfortunately, with this commit they introduced a new dependency for tests: - sorry for not seeing this (I did run tests, but on Windows not everything is executed) https://github.com/apache/hadoop/commit/1d017040605b64c7092d8e83d057f4427044aa87

          I have to add another old Mortbay-Jetty dependency for tests. I will check again.

          Show
          thetaphi Uwe Schindler added a comment - Unfortunately, with this commit they introduced a new dependency for tests: - sorry for not seeing this (I did run tests, but on Windows not everything is executed) https://github.com/apache/hadoop/commit/1d017040605b64c7092d8e83d057f4427044aa87 I have to add another old Mortbay-Jetty dependency for tests. I will check again.
          Hide
          thetaphi Uwe Schindler added a comment -

          This patch fixes the remaining issue. It also adds another thread filter.

          Show
          thetaphi Uwe Schindler added a comment - This patch fixes the remaining issue. It also adds another thread filter.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit cf051abcb9f8385e5de65de6c08468e31707f2d2 in lucene-solr's branch refs/heads/master from Uwe Schindler
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=cf051ab ]

          SOLR-11261: Fix missing dependency & add new thread filter

          Show
          jira-bot ASF subversion and git services added a comment - Commit cf051abcb9f8385e5de65de6c08468e31707f2d2 in lucene-solr's branch refs/heads/master from Uwe Schindler [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=cf051ab ] SOLR-11261 : Fix missing dependency & add new thread filter
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 6a8197619f803a131ab45f05ee26be1e69c062b3 in lucene-solr's branch refs/heads/branch_7x from Uwe Schindler
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=6a81976 ]

          SOLR-11261: Fix missing dependency & add new thread filter

          Show
          jira-bot ASF subversion and git services added a comment - Commit 6a8197619f803a131ab45f05ee26be1e69c062b3 in lucene-solr's branch refs/heads/branch_7x from Uwe Schindler [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=6a81976 ] SOLR-11261 : Fix missing dependency & add new thread filter
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 04c63953cb35b9e921544be7989d2d67a707c159 in lucene-solr's branch refs/heads/branch_7_0 from Uwe Schindler
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=04c6395 ]

          SOLR-11261, SOLR-10966: Upgrade to Hadoop 2.7.4 to fix incompatibility with Java 9.
          This also reverts commit 85a27a231fdddb118ee178baac170da0097a02c0.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 04c63953cb35b9e921544be7989d2d67a707c159 in lucene-solr's branch refs/heads/branch_7_0 from Uwe Schindler [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=04c6395 ] SOLR-11261 , SOLR-10966 : Upgrade to Hadoop 2.7.4 to fix incompatibility with Java 9. This also reverts commit 85a27a231fdddb118ee178baac170da0097a02c0.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 75141efada4520c36b4b87a4e05b4ef1eff886a0 in lucene-solr's branch refs/heads/branch_7_0 from Uwe Schindler
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=75141ef ]

          SOLR-11261: Fix missing dependency & add new thread filter

          Show
          jira-bot ASF subversion and git services added a comment - Commit 75141efada4520c36b4b87a4e05b4ef1eff886a0 in lucene-solr's branch refs/heads/branch_7_0 from Uwe Schindler [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=75141ef ] SOLR-11261 : Fix missing dependency & add new thread filter
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit c221a596fe23088ae8cee1ff41e7dcf186e3b402 in lucene-solr's branch refs/heads/branch_6x from Uwe Schindler
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c221a59 ]

          SOLR-11261, SOLR-10966: Upgrade to Hadoop 2.7.4 to fix incompatibility with Java 9.
          This also reverts commit 85a27a231fdddb118ee178baac170da0097a02c0.

          Show
          jira-bot ASF subversion and git services added a comment - Commit c221a596fe23088ae8cee1ff41e7dcf186e3b402 in lucene-solr's branch refs/heads/branch_6x from Uwe Schindler [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c221a59 ] SOLR-11261 , SOLR-10966 : Upgrade to Hadoop 2.7.4 to fix incompatibility with Java 9. This also reverts commit 85a27a231fdddb118ee178baac170da0097a02c0.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 3916fe793a507160b937e5de426da58892f4cf9c in lucene-solr's branch refs/heads/branch_6x from Uwe Schindler
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=3916fe7 ]

          SOLR-11261: Fix missing dependency & add new thread filter

          Show
          jira-bot ASF subversion and git services added a comment - Commit 3916fe793a507160b937e5de426da58892f4cf9c in lucene-solr's branch refs/heads/branch_6x from Uwe Schindler [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=3916fe7 ] SOLR-11261 : Fix missing dependency & add new thread filter
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit e0b54e6552775e2f71591e772bceb758c8428783 in lucene-solr's branch refs/heads/branch_6_6 from Uwe Schindler
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e0b54e6 ]

          SOLR-11261, SOLR-10966: Upgrade to Hadoop 2.7.4 to fix incompatibility with Java 9.
          This also reverts commit 85a27a231fdddb118ee178baac170da0097a02c0.

          1. Conflicts:
          2. solr/CHANGES.txt
          Show
          jira-bot ASF subversion and git services added a comment - Commit e0b54e6552775e2f71591e772bceb758c8428783 in lucene-solr's branch refs/heads/branch_6_6 from Uwe Schindler [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e0b54e6 ] SOLR-11261 , SOLR-10966 : Upgrade to Hadoop 2.7.4 to fix incompatibility with Java 9. This also reverts commit 85a27a231fdddb118ee178baac170da0097a02c0. Conflicts: solr/CHANGES.txt
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 0ad7440bb7476d059a5717e1cb18c3f45a52825e in lucene-solr's branch refs/heads/branch_6_6 from Uwe Schindler
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=0ad7440 ]

          SOLR-11261: Fix missing dependency & add new thread filter

          Show
          jira-bot ASF subversion and git services added a comment - Commit 0ad7440bb7476d059a5717e1cb18c3f45a52825e in lucene-solr's branch refs/heads/branch_6_6 from Uwe Schindler [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=0ad7440 ] SOLR-11261 : Fix missing dependency & add new thread filter
          Hide
          shalinmangar Shalin Shekhar Mangar added a comment -

          Bulk close after 7.1.0 release

          Show
          shalinmangar Shalin Shekhar Mangar added a comment - Bulk close after 7.1.0 release

            People

            • Assignee:
              thetaphi Uwe Schindler
              Reporter:
              thetaphi Uwe Schindler
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development