Solr
  1. Solr
  2. SOLR-1110

Investigate Sorting on Trie field types with DistributedSearch

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.4
    • Component/s: search
    • Labels:
      None

      Description

      Need to write tests to determine if Trie sorting will work correctly with DistributedSearch, given the usage of Investigate Sorting on Trie field types with DistributedSearch. If not, we need to figure out how to fix this.

      Refer to Uwe Schindler's comment on SOLR-940:

      One note to sorting:
      I am not really sure, if sorting works with Solr. The Sortfield returned by TrieUtils.getSortField contains an own parser (new feature in Lucene 2.9). When looking through the solr code, searching for SortField in trunk, I noticed, that QueryComponent has own comparators and FieldCache code (duplicating the Lucene code), and ignoring the parser given in SortField (the parser is not passed to FieldCache.getInts() & Co.).

      If this is the case, it will simply not work.

      OK. If distributed search does not work, the problems are bigger: The problem is not the comparator alone, the problem is the FieldCache. The distributed search should fill the values into FieldCache and then let the comparator do the work. Comparing lucenes code with the solr ones shows, that there are some parts of LUCENE-1478 missing. The Comparators use the default parser instead of the one given in SortField.getParser() to parse the values (when retrieving FieldCache.getInts() & Co).

      I am not really sure, why Solr needs to duplicate the sorting code from Lucene? Maybe this is no longer needed? In this case, everything would be ok when removed.

      1. SOLR-1110.patch
        10 kB
        Mark Miller

        Issue Links

          Activity

          Hide
          Mark Miller added a comment -

          test+fix, all test pass

          Show
          Mark Miller added a comment - test+fix, all test pass
          Hide
          Shalin Shekhar Mangar added a comment -

          Committed revision 769040.

          Thanks Mark!

          Show
          Shalin Shekhar Mangar added a comment - Committed revision 769040. Thanks Mark!
          Hide
          Grant Ingersoll added a comment -

          Bulk close for Solr 1.4

          Show
          Grant Ingersoll added a comment - Bulk close for Solr 1.4

            People

            • Assignee:
              Shalin Shekhar Mangar
              Reporter:
              Shalin Shekhar Mangar
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development