Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-11014

server/solr-webapp/** missing for the eclipse exclusions in build.xml

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 5.0, 6.0, 7.0
    • Fix Version/s: None
    • Component/s: Build
    • Labels:

      Description

      in the top folder, in build.xml
      https://github.com/apache/lucene-solr/blob/branch_6_6/build.xml

      in the "eclipse" target (line 442, branch_6_6)

         <pathconvert property="eclipse.fileset.libs" pathsep="|" dirsep="/">
            <fileset dir="${basedir}/lucene" includes="**/lib/*.jar" excludes="**/*servlet-api*.jar, analysis/uima/**, tools/**, build/**"/>
            <fileset dir="${basedir}/solr" includes="**/test-lib/*.jar,**/lib/*.jar" excludes="core/test-lib/*servlet-api*.jar, contrib/analysis-extras/**, test-framework/lib/junit*, test-framework/lib/ant*, test-framework/lib/randomizedtesting*, build/**, dist/**, package/**" />
            <map from="${basedir}/" to=""/>
          </pathconvert>
      

      Just like in the netbeans target, the fileset excluded should have "server/solr-webapp/**" also at the end.Otherwise, if I do "ant-eclipse" after "ant generate-maven-artifacts", i get eclipse errors like:
      "The type FacetDoubleMerger is already defined FacetModule.java /solr6_/solr/core/src/java/org/apache/solr/search/facet line 364"

      because

      <classpathentry kind="lib" path="solr/server/solr-webapp/webapp/WEB-INF/lib/solr-core-6.6.0-SNAPSHOT.jar"/>
      

      was included in my ".classpath" during the "ant-eclipse" phase.

      So at the end of the line

      <fileset dir="${basedir}/solr" includes="**/test-lib/*.jar,**/lib/*.jar" excludes="core/test-lib/*servlet-api*.jar, contrib/analysis-extras/**, test-framework/lib/junit*, test-framework/lib/ant*, test-framework/lib/randomizedtesting*, build/**, dist/**, package/**" />
      

      we should also add:

      <fileset dir="${basedir}/solr" includes="**/test-lib/*.jar,**/lib/*.jar" excludes="core/test-lib/*servlet-api*.jar, contrib/analysis-extras/**, test-framework/lib/junit*, test-framework/lib/ant*, test-framework/lib/randomizedtesting*, build/**, dist/**, package/**, server/solr-webapp/**" />
      

      Thank you.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              alefloch Antoine Le Floc'h
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated: