Solr
  1. Solr
  2. SOLR-1092

DIH can have a new command "import" which does not clean

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.4
    • Labels:
      None

      Description

      full-import is slightly risky that it cleans the index if we fail to mention clean= false. We must add a command import which will work like full-import and does not clean

      1. SOLR-1092.patch
        3 kB
        Shalin Shekhar Mangar
      2. SOLR-1092.patch
        3 kB
        Noble Paul

        Activity

        Hide
        Noble Paul added a comment -

        this also fixes the bug where clean is done even if clean=false is set

        Show
        Noble Paul added a comment - this also fixes the bug where clean is done even if clean=false is set
        Hide
        Shalin Shekhar Mangar added a comment -

        this also fixes the bug where clean is done even if clean=false is set

        Actually the clean parameter is being checked inside cleanByQuery method. I'll commit the rest of the changes shortly.

        Show
        Shalin Shekhar Mangar added a comment - this also fixes the bug where clean is done even if clean=false is set Actually the clean parameter is being checked inside cleanByQuery method. I'll commit the rest of the changes shortly.
        Hide
        Shalin Shekhar Mangar added a comment -

        Committed revision 770980.

        Thanks Noble!

        Show
        Shalin Shekhar Mangar added a comment - Committed revision 770980. Thanks Noble!
        Hide
        Shalin Shekhar Mangar added a comment -

        Import command does not commit documents.

        Show
        Shalin Shekhar Mangar added a comment - Import command does not commit documents.
        Hide
        Shalin Shekhar Mangar added a comment -

        Fix with test.

        Show
        Shalin Shekhar Mangar added a comment - Fix with test.
        Hide
        Shalin Shekhar Mangar added a comment -

        Committed revision 819170.

        Show
        Shalin Shekhar Mangar added a comment - Committed revision 819170.
        Hide
        Grant Ingersoll added a comment -

        Bulk close for Solr 1.4

        Show
        Grant Ingersoll added a comment - Bulk close for Solr 1.4

          People

          • Assignee:
            Shalin Shekhar Mangar
            Reporter:
            Noble Paul
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development