Solr
  1. Solr
  2. SOLR-1080

RegexTransformer should not replace if regex is not matched

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.4
    • Labels:
      None

      Description

      If the regex is not matched , the replaceWith should be ignored

      1. SOLR-1080.patch
        3 kB
        Fergus McMenemie
      2. SOLR-1080.patch
        0.8 kB
        Noble Paul

        Activity

        Hide
        Noble Paul added a comment -

        the fix

        Show
        Noble Paul added a comment - the fix
        Hide
        Shalin Shekhar Mangar added a comment -

        Committed revision 757140.

        Thanks Noble!

        Show
        Shalin Shekhar Mangar added a comment - Committed revision 757140. Thanks Noble!
        Hide
        Fergus McMenemie added a comment -

        I will update the wiki to cover this when I am adding stuff for SOLR1060

        Show
        Fergus McMenemie added a comment - I will update the wiki to cover this when I am adding stuff for SOLR1060
        Hide
        Fergus McMenemie added a comment -

        An improved version of TestRegexTransformer.

        Previous versions checked that all was good when a pattern matched. There were no checks that involved mismatches. Also there are now a number of mutually exclusive options. A check was added for one permutation of the available attributes.

        Show
        Fergus McMenemie added a comment - An improved version of TestRegexTransformer. Previous versions checked that all was good when a pattern matched. There were no checks that involved mismatches. Also there are now a number of mutually exclusive options. A check was added for one permutation of the available attributes.
        Hide
        Shalin Shekhar Mangar added a comment -

        Committed revision 765559.

        Thanks Fergus!

        Show
        Shalin Shekhar Mangar added a comment - Committed revision 765559. Thanks Fergus!
        Hide
        Grant Ingersoll added a comment -

        Bulk close for Solr 1.4

        Show
        Grant Ingersoll added a comment - Bulk close for Solr 1.4

          People

          • Assignee:
            Shalin Shekhar Mangar
            Reporter:
            Noble Paul
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development