Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-108

Some basic clean up and validation for Solr::Request::Standard

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: clients - ruby - flare
    • Labels:
      None
    • Environment:

      Darwin rocket 8.8.1 Darwin Kernel Version 8.8.1: Mon Sep 25 19:42:00 PDT 2006; root:xnu-792.13.8.obj~1/RELEASE_I386 i386 i386

      Description

      This is a slightly different approach from the one you took. If we get a hash in, and we want a hash out, why convert it to instance variables? This could even be taken a step further, why not create the hash that solr will need on initialization? Anyway, it does some basic validation, and passes all tests.

        Attachments

        1. request_standard.patch
          4 kB
          William Groppe

          Activity

            People

            • Assignee:
              ehatcher Erik Hatcher
              Reporter:
              willgroppe William Groppe
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: