[SOLR-10757] cleanup/refactor/fix deprecated methods/constructors in CollectionAdminRequest

• Type: Task
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Fix Version/s: 7.0
• Assignee: Chris M. Hostetter
• Reporter: Chris M. Hostetter
• Created: 26/May/17 17:05
• Updated: 08/Jun/19 15:19
• Resolved: 31/May/17 17:06

Description

spinning off of SOLR-10755...

• CollectionAdminRequest
  • has roughly double the number of deprecations of all other solrj classes combined
  • many of the deprecated methods/constructors are still used in a lot of places in tests
  • in many cases the non-deprecated "constructor" versions aren't validating the same way the deprecated setters do
  • in at least one case i see obvious bugs in the non-deprecated methods (see ForceLeader constructors)
  • once many of these deprecated setters are removed, a lot of member variables should become final

Issue Links

• is related to: SOLR-10755 delete/refactor (most) solrj deprecations on master
• relates to: SOLR-10788 make more CollectionAdminRequest variables final