Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-1026

SnowballPorterFilterFactory does not support protected words

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.3
    • Fix Version/s: 1.4
    • Component/s: Schema and Analysis
    • Labels:
      None
    1. SOLR-1026.patch
      9 kB
      Erik Hatcher

      Activity

      Hide
      ehatcher Erik Hatcher added a comment -

      Copy/paste fix for the issue from EnglishPorterFilterFactory.

      Better would be to put some base protected word infrastructure in place that other filters could leverage, but this works for now, and isn't all that horrible

      Show
      ehatcher Erik Hatcher added a comment - Copy/paste fix for the issue from EnglishPorterFilterFactory. Better would be to put some base protected word infrastructure in place that other filters could leverage, but this works for now, and isn't all that horrible
      Hide
      ehatcher Erik Hatcher added a comment -

      With this, is there any reason to keep EnglishPorterFilterFactory? SnowballPorterFilterFactory with langauge="English" is the same thing, right? Maybe we deprecate EPFF? Objections? Is the reflection thing an issue? The SnowballProgram is created in #create.

      Show
      ehatcher Erik Hatcher added a comment - With this, is there any reason to keep EnglishPorterFilterFactory? SnowballPorterFilterFactory with langauge="English" is the same thing, right? Maybe we deprecate EPFF? Objections? Is the reflection thing an issue? The SnowballProgram is created in #create.
      Hide
      yseeley@gmail.com Yonik Seeley added a comment -

      The reflection used to be much worse because it was invoked per token. That's been fixed, so now it's just Class.newInstance() per filter creation which shouldn't be as big of a deal.

      Show
      yseeley@gmail.com Yonik Seeley added a comment - The reflection used to be much worse because it was invoked per token. That's been fixed, so now it's just Class.newInstance() per filter creation which shouldn't be as big of a deal.
      Hide
      gsingers Grant Ingersoll added a comment -

      Bulk close for Solr 1.4

      Show
      gsingers Grant Ingersoll added a comment - Bulk close for Solr 1.4

        People

        • Assignee:
          ehatcher Erik Hatcher
          Reporter:
          ehatcher Erik Hatcher
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development