Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-10124

Replication can skip removing a temporary index directory in some cases when it should not.

        Details

        • Type: Bug
        • Status: Closed
        • Priority: Minor
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: 6.5, 7.0
        • Component/s: None
        • Security Level: Public (Default Security Level. Issues are Public)
        • Labels:
          None

          Description

          We wait to say it's okay to delete the directory until after modifyIndexProps is done, but then we assume it was successful when setting deleteTmpIdxDir rather than checking the result.

            Issue Links

            relates to

            Test - A new unit, integration or system test. SOLR-10119 TestReplicationHandler has always been too good at finding too many annoying bugs.

            • Critical - Crashes, loss of data, severe memory leak.
            • Open

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              jira-bot ASF subversion and git services added a comment -

              Commit 2196663156d2d72bc61e72c296a2c778754f881f in lucene-solr's branch refs/heads/master from markrmiller
              [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=2196663 ]

              SOLR-10120: A SolrCore reload can remove the index from the previous SolrCore during replication index rollover.
              SOLR-10124: Replication can skip removing a temporary index directory in some cases when it should not.
              SOLR-10119: Harden TestReplicationHandler.

              Show
              jira-bot ASF subversion and git services added a comment - Commit 2196663156d2d72bc61e72c296a2c778754f881f in lucene-solr's branch refs/heads/master from markrmiller [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=2196663 ] SOLR-10120 : A SolrCore reload can remove the index from the previous SolrCore during replication index rollover. SOLR-10124 : Replication can skip removing a temporary index directory in some cases when it should not. SOLR-10119 : Harden TestReplicationHandler.
              Hide
              Permalink
              jira-bot ASF subversion and git services added a comment -

              Commit 53beb4989e2acaf111c00f59d57f7812a88e3a2f in lucene-solr's branch refs/heads/branch_6x from markrmiller
              [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=53beb49 ]

              SOLR-10120: A SolrCore reload can remove the index from the previous SolrCore during replication index rollover.
              SOLR-10124: Replication can skip removing a temporary index directory in some cases when it should not.
              SOLR-10119: Harden TestReplicationHandler.

              1. Conflicts:
              2. solr/CHANGES.txt
              3. solr/core/src/java/org/apache/solr/core/SolrCore.java
              4. solr/core/src/java/org/apache/solr/handler/IndexFetcher.java
              5. solr/core/src/test/org/apache/solr/handler/TestReplicationHandler.java
              Show
              jira-bot ASF subversion and git services added a comment - Commit 53beb4989e2acaf111c00f59d57f7812a88e3a2f in lucene-solr's branch refs/heads/branch_6x from markrmiller [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=53beb49 ] SOLR-10120 : A SolrCore reload can remove the index from the previous SolrCore during replication index rollover. SOLR-10124 : Replication can skip removing a temporary index directory in some cases when it should not. SOLR-10119 : Harden TestReplicationHandler. Conflicts: solr/CHANGES.txt solr/core/src/java/org/apache/solr/core/SolrCore.java solr/core/src/java/org/apache/solr/handler/IndexFetcher.java solr/core/src/test/org/apache/solr/handler/TestReplicationHandler.java

                People

                • Assignee:
                  markrmiller@gmail.com Mark Miller
                  Reporter:
                  markrmiller@gmail.com Mark Miller
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Development