ServiceMix Components
  1. ServiceMix Components
  2. SMXCOMP-315

ServiceMix http binding component should allow option to create jetty Client per HttpProvider.

    Details

    • Patch Info:
      Patch Available

      Description

      Currently servicemix-http binding component requires all HttpProviderEndpoints to use one shared jetty HttpClient for request dispatch.
      I am attaching a patch which will keep this default behaviour but will allow HttpComponent to configure in such a way that each HttpProviderComponent can have it's own jetty HttpClient.

      Currently, bug in jetty HttpClient freezes Servicemix under heavy load when Jetty Threadpool size is lower than maxConnectionPerHost. This fix along with configurable threadpool fix applied by Guillaume will allow servicemix to be more responsive.

      I have attached a patch with the Jira.

        Activity

        Hide
        Guillaume Nodet added a comment -

        Btw, I've recently modified the configuration of the jetty client to use non blocking nio selectors instead of standard sockets, and this also seems to work much better and does not lead to a freeze afaik.
        This does not prevent us from applying this patch of course, but i thought it would be worth mentioning ...

        Show
        Guillaume Nodet added a comment - Btw, I've recently modified the configuration of the jetty client to use non blocking nio selectors instead of standard sockets, and this also seems to work much better and does not lead to a freeze afaik. This does not prevent us from applying this patch of course, but i thought it would be worth mentioning ...
        Hide
        Ulhas Bhole added a comment -

        Hi Guillaume,
        Good to know about the nio selector stuff. I actually raised JIRA on jetty and Greg suggested the same but did caution that there are some connection closing issues which are fixed in Jetty 7.0 and will back port them to Jetty 6 also (possibly in next release jetty 6.1.12).

        Do you think it's good Idea to move to latest Jetty version once 7.0 is release or stay on Jetty 6?

        Also, I think applying this patch also would be good because it's not changing the default behaviour but gives ability to have some flexibility if someone requires it.

        Regards,

        Ulhas Bhole

        Show
        Ulhas Bhole added a comment - Hi Guillaume, Good to know about the nio selector stuff. I actually raised JIRA on jetty and Greg suggested the same but did caution that there are some connection closing issues which are fixed in Jetty 7.0 and will back port them to Jetty 6 also (possibly in next release jetty 6.1.12). Do you think it's good Idea to move to latest Jetty version once 7.0 is release or stay on Jetty 6? Also, I think applying this patch also would be good because it's not changing the default behaviour but gives ability to have some flexibility if someone requires it. Regards, Ulhas Bhole
        Hide
        Ulhas Bhole added a comment -

        Forgot to mention, I require the fix on 3.2 branch. Is the nio selector stuff changed only on trunk or on 3.2 also?

        Regards,

        Ulhas Bhole

        Show
        Ulhas Bhole added a comment - Forgot to mention, I require the fix on 3.2 branch. Is the nio selector stuff changed only on trunk or on 3.2 also? Regards, Ulhas Bhole
        Hide
        Gert Vanthienen added a comment -

        Fixed for 3.2 branch in http://svn.eu.apache.org/viewvc?view=rev&revision=679817. Thank you for providing the patch!
        Unfortunately, this patch cannot be applied to the components trunk. Could you make a new one for that?

        Show
        Gert Vanthienen added a comment - Fixed for 3.2 branch in http://svn.eu.apache.org/viewvc?view=rev&revision=679817 . Thank you for providing the patch! Unfortunately, this patch cannot be applied to the components trunk. Could you make a new one for that?
        Hide
        Ulhas Bhole added a comment -

        New patch for servicemix-http component on trunk.

        Show
        Ulhas Bhole added a comment - New patch for servicemix-http component on trunk.
        Hide
        Freeman Fang added a comment -

        patch get applied with thanks to Ulhas Bhole

        http://svn.apache.org/viewvc?rev=680227&view=rev

        Show
        Freeman Fang added a comment - patch get applied with thanks to Ulhas Bhole http://svn.apache.org/viewvc?rev=680227&view=rev

          People

          • Assignee:
            Ulhas Bhole
            Reporter:
            Ulhas Bhole
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development