[SM-892] ManagementContext.shutdown() calls wrong method to unregister MBeans

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.1
• Fix Version/s: 3.1.1, 3.2
• Component/s: servicemix-core

Environment

All

• Assignee: Guillaume Nodet
• Reporter: David Potter
• Created: 21/Mar/07 23:20
• Updated: 22/Mar/07 14:15
• Resolved: 22/Mar/07 14:15

Description

The problem code is:
Object[] beans = beanMap.keySet().toArray();
for (int i = 0; i < beans.length; i++) {
try

{ unregisterMBean(beans[i]); }

catch (Exception e)

{ log.debug("Could not unregister mbean", e); }

}

The object[] will contain the keys - these is an array of ObjectName but they are typed as Object

There are two unregisterMBean methods unregisterMBean(Object bean) and unregisterMBean(ObjectName name).

The code will now call unregisterMBean(Object bean) when we want it to call unregisterMBean(ObjectName name). this will result in no beans being unregisters from this method.

The fix is, I think, to cast bean[i] to an ObjectName in the method call.