[SM-3468] OSGi bundle for Brave-zipkin 3.7.0 needs private packages for zipkin shaded

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: bundles-2017.08
• Component/s: bundles
• Flags: Patch
• Assignee: Freeman Yue Fang
• Reporter: Bob Paulin
• Created: 31/Aug/17 02:23
• Updated: 31/Aug/17 03:01
• Resolved: 31/Aug/17 03:01

Description

Currently the brave-core 3.7.0 bundle is shading in the zipkin package dependencies under com.github.kristofa.brave.internal.zipkin
see https://github.com/openzipkin/brave/blob/brave-3.7.0/brave-core/pom.xml

Since these packages are not exported they are not being pulled into the bundle and causing ClassNotFoundExceptions in OSGi runtimes. (Tested with Karaf 4.0.7).

By adding them as package private they will remain private to the bundle and get properly included.

Issue Links

• links to: GitHub Pull Request #106