[SM-2620] Service Wrapper installer generating broken karaf-wrapper.conf

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Not A Problem
• Affects Version/s: 6.0.0
• Component/s: features

Environment

Windows Server 2008 R2
Java JDK 1.8.0_45

• Assignee: Freeman Yue Fang
• Reporter: George Daswani
• Created: 13/Jul/15 07:16
• Updated: 14/Jul/15 02:54
• Resolved: 14/Jul/15 02:54

Description

This affects the latest version of ServiceMix 6.0 that was just recently released. When performing a

"feature:install service-wrapper"

then

"wrapper:install"

The GENERATED "karaf-wrapper.conf" is broken due to a numbering issue on the wrapper.java.classpath.X name value pairs and it prevents the service from starting.

Here is what it generates by default (after performing wrapper:install)

1. Java Application
   wrapper.working.dir=%KARAF_BASE%
   wrapper.java.command=%JAVA_HOME%/bin/java
   wrapper.java.mainclass=org.apache.karaf.wrapper.internal.Main
   wrapper.java.classpath.1=%KARAF_HOME%/lib/karaf-wrapper.jar
   wrapper.java.classpath.2=%KARAF_HOME%/lib/karaf.jar
   wrapper.java.classpath.4=%KARAF_HOME%/lib/karaf-jaas-boot.jar
   wrapper.java.classpath.5=%KARAF_HOME%/lib/karaf-wrapper-main.jar
   wrapper.java.classpath.6=%KARAF_HOME%/lib/karaf-org.osgi.core.jar
   wrapper.java.library.path.1=%KARAF_HOME%/lib/

^ Note: the number is wrong, and the original conf file generated skipped the sequence wrapper.java.classpath.3 and it prevents servicemix from starting. The wrapper throws an error saying it can't find the main class.

Here's what it should have generated

1. Java Application
   wrapper.working.dir=%KARAF_BASE%
   wrapper.java.command=%JAVA_HOME%/bin/java
   wrapper.java.mainclass=org.apache.karaf.wrapper.internal.Main
   wrapper.java.classpath.1=%KARAF_HOME%/lib/karaf-wrapper.jar
   wrapper.java.classpath.2=%KARAF_HOME%/lib/karaf.jar
   wrapper.java.classpath.3=%KARAF_HOME%/lib/karaf-jaas-boot.jar
   wrapper.java.classpath.4=%KARAF_HOME%/lib/karaf-wrapper-main.jar
   wrapper.java.classpath.5=%KARAF_HOME%/lib/karaf-org.osgi.core.jar
   wrapper.java.library.path.1=%KARAF_HOME%/lib/