[SM-1937] Incorrect logic in throttle method of DeliveryChannelImpl.java

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.3.1
• Fix Version/s: 3.3.2
• Component/s: servicemix-core
• Assignee: Freeman Yue Fang
• Reporter: Alexander Zobkov
• Created: 02/Mar/10 09:16
• Updated: 03/Mar/10 07:55
• Resolved: 03/Mar/10 07:55

Description

It seems something wrong with logic of the following method in DeliveryChannelImpl.java file:

    protected void throttle() {
        if (component.isExchangeThrottling()) {
            if (component.getThrottlingInterval() > intervalCount) {
                intervalCount = 0;
                try {
                    Thread.sleep(component.getThrottlingTimeout());
                } catch (InterruptedException e) {
                    LOG.warn("throttling failed", e);
                }
            }
            intervalCount++;
        }
    }

if user specifies positive values (default value is 1) of throttlingInterval then "if" statement is always true. So user need to specify negative values of throttlingInterval in order to not force thread sleep on each doSend method. Also it would be good to add a little bit logging here. So I propose the following modification:

    protected void throttle() {
        if (component.isExchangeThrottling()) {
            if (component.getThrottlingInterval() < intervalCount) {
                intervalCount = 0;
                try {
                    long timeout = component.getThrottlingTimeout()
                    LOG.debug("throttling, sleep for: "+timeout);
                    Thread.sleep(timeout);
                } catch (InterruptedException e) {
                    LOG.warn("throttling failed", e);
                }
            }
            intervalCount++;
        }
    }