[SM-1161] jbi-service-unit causes infinite loop when dependency graph is not cycle-free

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 3.2, 3.2.1
• Fix Version/s: 3.2.2, 3.3
• Component/s: tooling

Environment

mvn 2.0.6, win xp pro

• Patch Info: Patch Available
• Assignee: Bruce Snyder
• Reporter: Tammo van Lessen
• Created: 03/Dec/07 21:57
• Updated: 07/Mar/08 15:28
• Resolved: 07/Mar/08 15:28

Description

Hi,

when building a JSR181 SU, maven dies in a StackOverflowException, caused by an infinite loop in AbstractJBIMojo.getArtifacts(). My guess is that one of the used libraries draws some
transitive dependencies, which have have a cycle.

[ERROR] FATAL ERROR
[INFO] ------------------------------------------------------------------------
[INFO] null
[INFO] ------------------------------------------------------------------------
[INFO] Trace
java.lang.StackOverflowError
at org.apache.maven.artifact.DefaultArtifact.hashCode(DefaultArtifact.java:305)
at java.util.HashMap.put(HashMap.java:372)
at java.util.HashSet.add(HashSet.java:200)
at org.apache.servicemix.maven.plugin.jbi.AbstractJbiMojo.getArtifacts(AbstractJbiMojo.java:
144)
at org.apache.servicemix.maven.plugin.jbi.AbstractJbiMojo.getArtifacts(AbstractJbiMojo.java:
147)
at org.apache.servicemix.maven.plugin.jbi.AbstractJbiMojo.getArtifacts(AbstractJbiMojo.java:
147)
at org.apache.servicemix.maven.plugin.jbi.AbstractJbiMojo.getArtifacts(AbstractJbiMojo.java:
147)
...

I had a look at the code and are wondering whether the exit condition of the recursive getArtifacts() methods should also check if the artifact has already been processed.
The same applies to the debug method "print".

Please find attached a patch against SM 3.2.1 which fixes that (unless I did not get the original intention of getArtifacts() wrong).

Thanks,
Tammo