[SM-1012] Possible resource leak in FilePoller

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.1.1
• Fix Version/s: 3.1.2, 3.2
• Component/s: servicemix-file

Environment

Windows XP, JDK 5.0

• Assignee: Guillaume Nodet
• Reporter: Artur Karazniewicz
• Created: 28/Jul/07 16:59
• Updated: 30/Jul/07 15:13
• Resolved: 30/Jul/07 15:13

Description

In the org.apache.servicemix.components.file.FilePoller#processFile(File) it is possible that allocated file would leak. Now, it goes like:

protected void processFile(File aFile) throws Exception

{ String name = aFile.getCanonicalPath(); InputStream in = new BufferedInputStream(new FileInputStream(aFile)); InOnly exchange = getExchangeFactory().createInOnlyExchange(); NormalizedMessage message = exchange.createMessage(); exchange.setInMessage(message); marshaler.readMessage(exchange, message, in, name); getDeliveryChannel().sendSync(exchange); in.close(); }

But, we should properly clean-up in the case of exception thrown before in.close(). Thus, should be:

protected void processFile(File aFile) throws Exception {
InputStream in = null;
try

{ String name = aFile.getCanonicalPath(); in = new BufferedInputStream(new FileInputStream(aFile)); InOnly exchange = getExchangeFactory().createInOnlyExchange(); NormalizedMessage message = exchange.createMessage(); exchange.setInMessage(message); marshaler.readMessage(exchange, message, in, name); getDeliveryChannel().sendSync(exchange); }

finally {
if (in != null)

{ in.close(); }

}
}