[SLING-9870] NullPointerException, in case Locations are null in a GraphQL error response

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: GraphQL Core 0.0.6
• Fix Version/s: GraphQL Core 0.0.8
• Component/s: GraphQL
• Assignee: Bertrand Delacretaz
• Reporter: Jabran Asghar
• Created: 02/Nov/20 16:31
• Updated: 09/Nov/20 10:49
• Resolved: 03/Nov/20 09:35

Description

Problem

In case GraphQLError does not contain any Location information, rather when the list of locations will be null [0], then a NullPointerException is thrown. This causes a non-meaningful response to be sent back to client.

For example, the following query will cause a NPE:

{   article(_path: "/non-existent/path/to/an-article") 
    {     
        _path   
    } 
}

 
Proposed solution:
Should be a null check for error.getLocations().

[0] https://github.com/apache/sling-org-apache-sling-graphql-core/blob/e3b09af9e5bd9550e2df87491fd924a886eba51e/src/main/java/org/apache/sling/graphql/core/engine/DefaultQueryExecutor.java#L144

Issue Links

• causes: SLING-9872 Avoid logging unsanitized input
• links to: GitHub Pull Request #13