[SLING-8798] AclLine.getRestrictions should not return null

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: Repoinit Parser 1.3.2
• Component/s: Repoinit
• Assignee: Robert Munteanu
• Reporter: Angela Schreiber
• Created: 23/Oct/19 07:32
• Updated: 19/Nov/19 09:46
• Resolved: 24/Oct/19 09:38

Description

while trying to add nullable/notnull annotations in sling-jcr-repoinit to improve overall readability and maintainability of the code base, i noticed that AclLine.getRestrictions may return null. I would recommend to change this to be consistent with AclLine.getProperty, which returns an empty list in case no values exist for a given property name.

Proposed patch attached (including replacing a private static final EMPTY_LIST field by Collections.emptyList, which afaik is also defined to be immutable.