[SLING-8754] have OSGiServiceInjector reuse request bindings when possible

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Won't Fix
• Affects Version/s: Models Impl 1.4.10
• Fix Version/s: Models Impl 1.4.12
• Component/s: Sling Models
• Assignee: Nicolas Peltier
• Reporter: Nicolas Peltier
• Created: 01/Oct/19 13:59
• Updated: 28/Oct/19 10:38
• Resolved: 28/Oct/19 10:38

Description

right now OSGiServiceInjector uses its own bundle context for fetching the service reference, which generates ClassNotFoundException under the hood during assignable checks at each bind, which is bad for performances.

The annotation should either:

• use the context of the bundle it extends,
• use scripting core's ServiceCache,
• use the above through SlingScriptHelper

reusing the above works for request adaptable, not for resources, that will be treated in another ticket

cc radu justin

Issue Links

• links to: GitHub Pull Request #15