Uploaded image for project: 'Sling'
  1. Sling
  2. SLING-8619

RepoInitGrammer: Add repository-level marker to pathsList

Details

    Description

      In order to be able to cover repository level access control entrieswith the PrincipalAccessControlList (see SLING-8602), i would like to expand the RepoInitGrammer.pathsList() such that it not only handles absolute paths but in addition a marker for the repository level permissions (in JCR marked with a null path).

      essentially this would also create an alternative way to edit policies for the null path (today covered with set repository ACL ...).

      will provide a proposed patch and tests later this week.

      Attachments

        1. SLING-8619-parser-2.patch
          5 kB
          Angela Schreiber
        2. SLING-8619-parser.patch
          5 kB
          Angela Schreiber
        3. SLING-8619-jcr-2.patch
          5 kB
          Angela Schreiber
        4. SLING-8619-jcr.patch
          5 kB
          Angela Schreiber

        Issue Links

          Activity

            rombert, karlpauls, you have been recently working on the repo init code base. i would appreciate if you could review the 2 patches for sling-repoinit-parser and sling-jcr-repoinit respectively.

            note: the latter obviously needs to have the snapshot dependency to the parser replaced once the former is released. i just added it in order to have a patch that can be successfully build with passing tests.

            one more comment: i would have wished to include an update to the documentation along with the patches but didn't find it with either module... am i missing something?

            angela Angela Schreiber added a comment - rombert , karlpauls , you have been recently working on the repo init code base. i would appreciate if you could review the 2 patches for sling-repoinit-parser and sling-jcr-repoinit respectively. note: the latter obviously needs to have the snapshot dependency to the parser replaced once the former is released. i just added it in order to have a patch that can be successfully build with passing tests. one more comment: i would have wished to include an update to the documentation along with the patches but didn't find it with either module... am i missing something?

            Thanks for the patches angela, I think I managed to cover all dependencies and can start looking at this one now . One thing that stands out on a cursory review is the usage of null to mean 'whole repository'. Maybe we can use something more descriptive like 'repository'? I assume that we never use relative paths here.

            As for the documentation, what we have is at https://github.com/apache/sling-site/blob/master/src/main/jbake/content/documentation/bundles/repository-initialization.md .

            /cc bdelacretaz for the discussion on using null as the repository marker.

            rombert Robert Munteanu added a comment - Thanks for the patches angela , I think I managed to cover all dependencies and can start looking at this one now . One thing that stands out on a cursory review is the usage of null to mean 'whole repository'. Maybe we can use something more descriptive like 'repository'? I assume that we never use relative paths here. As for the documentation, what we have is at https://github.com/apache/sling-site/blob/master/src/main/jbake/content/documentation/bundles/repository-initialization.md . /cc bdelacretaz for the discussion on using null as the repository marker.

            rombert, i had "repository" initially and changed it back and forth.... so, i don't have a strong preference here. in the JCR API it's a null value.... but as i said, i don't feel strongly about it.

            angela Angela Schreiber added a comment - rombert , i had "repository" initially and changed it back and forth.... so, i don't have a strong preference here. in the JCR API it's a null value.... but as i said, i don't feel strongly about it.

            I agree that a descriptive name is more intuitive, would even suggest :repository with a leading colon to make it very clear that it's not a path.

            bdelacretaz Bertrand Delacretaz added a comment - I agree that a descriptive name is more intuitive, would even suggest :repository with a leading colon to make it very clear that it's not a path.

            :repository sounds good to me, thanks bdelacretaz. angela - could you please resubmit your changes using :repository instead of null? Thanks!

            rombert Robert Munteanu added a comment - :repository sounds good to me, thanks bdelacretaz . angela - could you please resubmit your changes using :repository instead of null ? Thanks!

            rombert, attached.

            angela Angela Schreiber added a comment - rombert , attached.
            rombert Robert Munteanu added a comment - Thank you for your patches, angela . I've applied them in sling-org-apache-sling-repoinit-parser commit 1567356 sling-org-apache-sling-jcr-repoinit commit af22095

            People

              rombert Robert Munteanu
              angela Angela Schreiber
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: