[SLING-8116] ValueMap - implement default methods using OSGI Converter

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: API 2.21.0, Resource Resolver 1.6.16
• Component/s: API
• Assignee: Radu Cotescu
• Reporter: Jason E Bailey
• Created: 16/Nov/18 15:26
• Updated: 03/May/22 23:09
• Resolved: 14/Nov/19 13:58

Description

Implement default methods in the ValueMap interface that leverages the OSGi Converter

see
https://osgi.org/specification/osgi.cmpn/7.0.0/util.converter.html

Once this is implemented, custom implementations of the ValueMap interface can start being removed, where appropriate, so that a consistent and comprehensive conversion of properties occur.  We can then add new Rules to the Converter to allow features to be populated to all ValueMap implementations.

 

To implement this, the following will also need to happen

• The Converter bundle will need to be added as a required bundle
  • Various scripts that define the minimum needed set of bundles will need to be updated
• Communication on the difference in behaviour between the current ValueMap and the ValueMap with Converter
• Although not within the Maven definition. org.osgi.util.Function needs to be available as well for the Converter to initiate correctly.

 

Issue Links

• causes: SLING-8943 The Sling API ObjectConverter does not correctly convert JCR values
• relates to: SLING-11294 Delegate ValueMap conversion to Sling API
• supercedes: SLING-7934 Add the ability for a resource to adapt to a JSONObject
• links to: GitHub Pull Request #8