[SLING-8114] Allow to do polling of code failing on asserts

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Won't Do
• Affects Version/s: Apache Sling Testing Clients 1.2.0
• Component/s: Apache Sling Testing Clients
• Assignee: Unassigned
• Reporter: Thierry Ygé
• Created: 16/Nov/18 14:20
• Updated: 15/Jan/24 09:04
• Resolved: 15/Jan/24 09:04

Description

Currently if you polling check uses assertions , it will not be retried, this is due to this line

https://github.com/apache/sling-org-apache-sling-testing-clients/blob/master/src/main/java/org/apache/sling/testing/clients/util/poller/Polling.java#L118

Which is only catching Exceptions while failing Assertions are an error kind (AssertionError).

It would be nice to handle it so that code wouldn't have to "transform" it to exception.

To reproduce simply use assertion in your polling check and let it fail if a counter is lower than a value. make the polling retries so that at the next retry counter it should pass.

 

int count = 0;

new Polling(() -> 

Unknown macro: {  count++;   Assert.assertTrue(count == 2);  return true;         }

).poll(2000, 500);

Observation: it exist the poll directly as the assert fail already.

Expected: It should have polled until the check pass here.