Details
-
Improvement
-
Status: Closed
-
Major
-
Resolution: Fixed
-
None
-
XSS Protection API 2.0.14, Scripting Core 2.0.56, Parent 34, JCR API 2.4.2, Auth Core 1.4.4, API 2.18.4, Models API 1.3.8, Content Distribution Core 0.3.0, Validation API 1.0.2, Scripting HTL Engine 1.0.56-1.4.0, Models Validation Impl 1.0.0, Log Tracer 1.0.8, Commons Messaging 1.0.0, Commons Messaging Mail 1.0.0, Scripting Thymeleaf 2.0.0, Oak Restrictions 1.0.2, Context-Aware Configuration API 1.1.2, MoM API 1.0.2, MoM JMS 1.0.2, MoM Jobs 1.0.2, Resource Presence 1.0.0, Discovery Commons 1.0.24, Context-Aware Configuration SPI 1.3.4, Models Jackson Exporter 1.1.0, Validation Core 1.0.6, Installer Core 3.9.0, Models Impl 1.4.10, Context-Aware Configuration Impl 1.4.14, Commons Clam 1.0.0, Resource Resolver 1.6.6, JCR Resource 3.0.16, Content Distribution API 0.4.0
-
None
Description
follow-up from SLING-7312 and discussion from the mailing list.
i will also start a vote on the mailing list about this, but this ticket describes the steps that are required.
about the jetbrains annotations:
- documentation: https://www.jetbrains.com/help/idea/nullable-and-notnull-annotations.html
- artifact: http://repo1.maven.org/maven2/org/jetbrains/annotations/16.0.2/
- although from jetbrans created for IntelliJ, they are also support by most other tooling (e.g. findbugs, sonar, configurable in Eclipse)
- apache 2.0 licensed: https://github.com/JetBrains/java-annotations
this search turned out that these modules are currently using JSR-305 annotations and need to be converted:
| Module | Switch | Released |
|---|---|---|
| org-apache-sling-api |  |
|
| org-apache-sling-auth-core | removed unused dependency |
- |
| org-apache-sling-caconfig-api | |
|
| org-apache-sling-caconfig-impl | |
|
| org-apache-sling-caconfig-spi | |
|
| org-apache-sling-commons-clam | |
|
| org-apache-sling-commons-messaging | no release yet |
- |
| org-apache-sling-commons-messaging-mail | no release yet |
- |
| org-apache-sling-discovery-commons | |
 |
| org-apache-sling-distribution-api | |
|
| org-apache-sling-distribution-avro-serializer | no release yet |
- |
| org-apache-sling-distribution-core | unit test fails (already before) |
|
| org-apache-sling-distribution-kryo-serializer | no release yet |
- |
| org-apache-sling-installer-core | |
|
| org-apache-sling-jcr-api | |
|
| org-apache-sling-jcr-resource | |
|
| org-apache-sling-jms | |
|
| org-apache-sling-jobs | |
|
| org-apache-sling-jobs-it-services | no release required |
- |
| org-apache-sling-models-api | |
|
| org-apache-sling-models-impl | |
|
| org-apache-sling-models-jacksonexporter | |
|
| org-apache-sling-models-validation-impl | no release yet |
- |
| org-apache-sling-mom | |
|
| org-apache-sling-oak-restrictions | |
|
| org-apache-sling-resource-presence | |
|
| org-apache-sling-resourceresolver | |
|
| org-apache-sling-scripting-core | |
|
| org-apache-sling-scripting-sightly | |
|
| org-apache-sling-scripting-thymeleaf | |
|
| org-apache-sling-tracer | |
|
| org-apache-sling-validation-api | |
|
| org-apache-sling-validation-core | |
|
| org-apache-sling-validation-test-services | no release required |
- |
| org-apache-sling-xss | |
|
| parent | |
|
| whiteboard/encrypt | no release required |
- |
| whiteboard/project-archetype/src/main/resources/archetype-resources | no release required |
- |
| whiteboard/scripting-resolver/org-apache-sling-scripting-resolver | no release required |
- |
steps to do:
- convert java sources and poms to jetbrains annotations and update package versions with the help of the convert-annotations.sh from
OAK-7511provided by reschke described here - update sling documentation: https://sling.apache.org/documentation/development/jsr-305.html
Attachments
Issue Links
- blocks
-
SLING-7312 Java 9 requires javax.annotation to be added to the classpath
-
- Closed
-
- causes
-
-
- Open
-
- is related to
-
OAK-7511 get rid of JSR 305 dependency - use jetbrains nullability annotations instead
-
- Closed
-
- supercedes
-
-
- Closed
-
-
-
- Closed
-