[SLING-7731] Call to addService is no longer needed for modification events in SlingAuthenticatorServiceListener

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Auth Core 1.3.18
• Fix Version/s: Auth Core 1.4.8
• Component/s: Authentication
• Assignee: Robert Munteanu
• Reporter: Vincent Frey
• Created: 13/Jun/18 11:29
• Updated: 22/Jun/20 12:15
• Resolved: 18/Jun/20 08:39

Description

After introduction of modifiedService(...) method in SlingAuthenticatorServiceListener, calling addService(...) is no longer needed for modification event.

https://github.com/apache/sling-org-apache-sling-auth-core/blob/master/src/main/java/org/apache/sling/auth/core/impl/SlingAuthenticatorServiceListener.java#L85

Therefore line 85 should be changed from:

if ((event.getType() & (ServiceEvent.REGISTERED | ServiceEvent.MODIFIED)) != 0) {

to:

if ((event.getType() & ServiceEvent.REGISTERED) != 0) {