[SLING-7586] [Sling Models] Memory Leak in cached adapters

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Sling Models Impl 1.4.0, Models Impl 1.4.2, Models Impl 1.4.4, Models Impl 1.4.6, Models Impl 1.4.8
• Fix Version/s: Models Impl 1.4.10
• Component/s: Extensions
• Assignee: Dan Klco
• Reporter: Justin Edelson
• Created: 17/Apr/18 11:48
• Updated: 24/Oct/18 22:40
• Resolved: 17/Oct/18 15:23

Description

There is a potential memory leak in the adapterCache in ModelAdapterFactory when the model class references the adaptable. The solution is to wrap the model object in a WeakReference. That ensures that the model can be GC'd and then the key can be GC'd.

Issue Links

• relates to: SLING-6785 Add support for scoped lifecycle of sling models
• links to: GitHub Pull Request #6
• links to: GitHub Pull Request #9