[SLING-7157] metatype.properties file must not be in OSGI-INF/metatype

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: JCR Web Console 1.0.2, JCR Registration 1.0.2, JCR ClassLoader 3.2.2, Form Based Authentication 1.0.8, Settings 1.3.8, Commons Threads 3.2.6, Auth Core 1.4.0, SLF4J MDC Filter 1.0.0, Authentication XING OAuth 0.0.2, Authentication XING Login 0.0.2, URL Rewriter 0.0.2, DataSource Provider 1.0.4, NoSQL MongoDB Resource Provider 1.1.0, Commons Log 5.0.2, Discovery Impl 1.2.12, Discovery Oak 1.2.18, JCR Davex 1.3.8, JCR Webdav 2.3.8, JCR Installer 3.1.26
• Fix Version/s: JCR Web Console 1.1.0, Settings 1.3.10, Auth Core 1.4.4, Mongo Resource Provider 1.0.0, Authentication XING OAuth 0.0.4, Authentication XING Login 0.0.4, URL Rewriter 0.0.4, Commons Log 5.1.0, Commons Threads 3.2.10, SLF4J MDC Filter 1.0.2, JCR Webdav 2.3.10, JCR Installer 3.2.0, Discovery Impl 1.2.14, JCR Davex 1.3.12, JCR ClassLoader 3.2.6, Discovery Oak 1.2.34
• Assignee: Carsten Ziegeler
• Reporter: Carsten Ziegeler
• Created: 27/Sep/17 12:15
• Updated: 07/Jun/21 13:44
• Resolved: 23/Apr/20 10:03

Description

According to the spec the metatype.properties file must not be inside the OSGI-INF/metatype directory. This is against the spec, so we should move it to OSGI-INF/l10n
We probably should also upgrade the maven-scr-plugin for this 1.25.0 or rather switch to OSGi annotations.

I found the following files:
./bundles/auth/core/src/main/resources/OSGI-INF/metatype/metatype.properties
./bundles/auth/form/src/main/resources/OSGI-INF/metatype/metatype.properties
./bundles/commons/log/src/main/resources/OSGI-INF/metatype/metatype.properties
./bundles/commons/threads/src/main/resources/OSGI-INF/metatype/metatype.properties
./bundles/extensions/discovery/impl/src/main/resources/OSGI-INF/metatype/metatype.properties
./bundles/extensions/discovery/oak/src/main/resources/OSGI-INF/metatype/metatype.properties
./bundles/extensions/settings/src/main/resources/OSGI-INF/metatype/metatype.properties
./bundles/jcr/classloader/src/main/resources/OSGI-INF/metatype/metatype.properties
./bundles/jcr/davex/src/main/resources/OSGI-INF/metatype/metatype.properties
./bundles/jcr/registration/src/main/resources/OSGI-INF/metatype/metatype.properties
./bundles/jcr/webconsole/src/main/resources/OSGI-INF/metatype/metatype.properties
./bundles/jcr/webdav/src/main/resources/OSGI-INF/metatype/metatype.properties
./contrib/auth/org.apache.sling.auth.xing.login/src/main/resources/OSGI-INF/metatype/metatype.properties
./contrib/auth/org.apache.sling.auth.xing.oauth/src/main/resources/OSGI-INF/metatype/metatype.properties
./contrib/extensions/datasource/src/main/resources/OSGI-INF/metatype/metatype.properties
./contrib/extensions/mongodb/src/main/resources/OSGI-INF/metatype/metatype.properties
./contrib/extensions/slf4j-mdc/src/main/resources/OSGI-INF/metatype/metatype.properties
./contrib/extensions/startup-filter/src/main/resources/OSGI-INF/metatype/metatype.properties
./contrib/extensions/urlrewriter/src/main/resources/OSGI-INF/metatype/metatype.properties
./installer/providers/jcr/src/main/resources/OSGI-INF/metatype/metatype.properties
./samples/path-based-rtp/src/main/resources/OSGI-INF/metatype/metatype.properties
./samples/workspacepicker/src/main/resources/OSGI-INF/metatype/metatype.properties
./testing/junit/core/src/main/resources/OSGI-INF/metatype/metatype.properties
./testing/junit/healthcheck/src/main/resources/OSGI-INF/metatype/metatype.properties

Module	Status
Auth Core
Auth Form
Commons Log
Commons Threads
Discovery Impl
Discovery Oak
Settings
JCR ClassLoader
JCR DavEx
JCR Registration
JCR WebConsole
JCR WebDav
Auth XING Login
Auth XING Oauth
Datasource	SLING-8282
MongoDB Resource Provider
SLF4J MDC Filter
Startup Filter	obsolete
URL Rewriter
Installer JCR Provider
Samples Path-based RTP
Samples Workspacepicker	obsolete
Testing JUnit Core
Testing JUnit Healthcheck

Issue Links

• is related to: SLING-8331 osgi-mock: JUnit 5 Extension - Support setting context member field in super classes
• relates to: FELIX-5700 Metatype generation wrongly puts properties files into metatype directory
• relates to: SLING-7264 Switch to OSGi annotation