[SLING-7020] DefaultDistributionComponentProvider is causing an NPE when agents are listed

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: Content Distribution Core 0.2.10
• Component/s: Content Distribution
• Environment: Latest Sling, JDK 1.8
• Assignee: Timothee Maret
• Reporter: Andreas Schaefer
• Created: 24/Jul/17 19:56
• Updated: 01/Oct/19 14:03
• Resolved: 25/Jul/17 13:30

Description

When listing the agents with ' /libs/sling/distribution/services.1.json' then the DefaultDistributionComponentProvider.getComponents() throws an NPE on line 84. The reason is that the method getComponentMap() for type TRIGGER is returning NULL and there is no check for a NPE. This will fix that NPE:

public List<DistributionComponent<?>> getComponents(DistributionComponentKind kind) {
Map<String, DistributionComponent<?>> componentMap = getComponentMap(kind.asClass());

List<DistributionComponent<?>> componentList = new ArrayList<DistributionComponent<?>>();
if(componentMap != null)

{ componentList.addAll(componentMap.values()); }

return componentList;
}