[SLING-6809] improve discovery's TopologyView toString

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Discovery Base 1.1.6
• Fix Version/s: Discovery Base 2.0.0
• Component/s: Extensions
• Assignee: Stefan Egli
• Reporter: Stefan Egli
• Created: 28/Apr/17 09:23
• Updated: 05/May/17 12:34
• Resolved: 05/May/17 12:34

Description

Consider the following log message:

... org.apache.sling.discovery.commons.providers.base.ViewStateManagerImpl enqueueForAll: sending topologyEvent TopologyEvent [type=PROPERTIES_CHANGED, oldView=DefaultTopologyView[current=false, num=5, instances=2466547c-eb7f-4f99-9716-9f1d95a97b24[local=false,leader=true],2466647c-eb7f-4f99-9716-9f1d97a97b87[local=false,leader=true],5466647c-eb7a-4f99-9716-9f1d97a34b85[local=false,leader=true],26101e4c-3488-44ef-b454-787d1673eb69[local=false,leader=true],48b217fb-93f7-4fff-bd96-b86509075c50[local=true,leader=true]], newView=DefaultTopologyView[current=true, num=5, instances=2466547c-eb7f-4f99-9716-9f1d95a97b24[local=false,leader=true],2466647c-eb7f-4f99-9716-9f1d97a97b87[local=false,leader=true],5466647c-eb7a-4f99-9716-9f1d97a34b85[local=false,leader=true],26101e4c-3488-44ef-b454-787d1673eb69[local=false,leader=true],48b217fb-93f7-4fff-bd96-b86509075c50[local=true,leader=true]]], ...

This output is misleading as it does not show which instance belongs to which cluster. That output (coming from DefaultTopologyView.toString()) should instead group the instances by clusterId to make this clear.