Uploaded image for project: 'Sling'
  1. Sling
  2. SLING-6609

Fix JSR305 annotations for ValueMap.get

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • API 2.16.2
    • API 2.16.4
    • API
    • None

    Description

      Currently <T> T get(@Nonnull String name, T defaultValue); does neither define a JSR 305 annotation for the return value nor for the 2nd parameter. It makes sense to define them both as @Nonnull, because if you intend to get null as return value you are supposed to take the other get method (@CheckForNull <T> T get(@Nonnull String name, @Nonnull Class<T> type))

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            kwin Konrad Windszus
            kwin Konrad Windszus
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment