[SLING-6477] Distributing with sling.jcr.api 2.2.0 should not throw NSME

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Content Distribution Core 0.1.10
• Fix Version/s: Content Distribution Core 0.2.0
• Component/s: Content Distribution
• Assignee: Timothee Maret
• Reporter: Tommaso Teofili
• Created: 19/Jan/17 10:18
• Updated: 14/Feb/17 09:30
• Resolved: 19/Jan/17 10:28

Description

In SLING-5281 we introduced capability of distributing with user session, however that requires sling.jcr.api-2.3.0 because of SlingRepository#impersonateFromService. In SLING-5633 the dependency to sling.jcr.api was moved from version 2.3.0 to 2.2.0 as to allow installation on older repositories.
On such old repos if an agent uses the calling user session the following Error appears:

Error executing handler
SimpleDistributionRequest{requestType=PULL, paths=[null]}
java.lang.NoSuchMethodError:
org.apache.sling.jcr.api.SlingRepository.impersonateFromService(Ljava/lang/
String;Ljavax/jcr/Credentials;Ljava/lang/String;)Ljavax/jcr/Session;
	at 
org.apache.sling.distribution.util.impl.DistributionUtils.getResourceResolv
er(DistributionUtils.java:89)

We should fallback to using the service user to login in such cases as to avoid such errors.