[SLING-6313] Sling installer can duplicate factory configurations if an invalid RegisteredResourceList.ser is found

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: Installer Core 3.9.0, Installer Configuration Factory 1.2.4
• Component/s: Installer
• Assignee: Carsten Ziegeler
• Reporter: Robert Munteanu
• Created: 21/Nov/16 12:35
• Updated: 26/May/21 20:59
• Resolved: 04/Sep/19 08:01

Description

Steps to reproduce, inside `launchpad/builder`

mvn clean package
java -jar target/org.apache.sling.launchpad-9-SNAPSHOT.jar
# wait for Sling to start up properly, stop it with CTRL-C
truncate --size=-1 sling/installer/RegisteredResourceList.ser
java -jar target/org.apache.sling.launchpad-9-SNAPSHOT.jar
# wait for Sling to start up properly, stop it with CTRL-C
java -jar target/org.apache.sling.launchpad-9-SNAPSHOT.jar

The following exceptions are logged in the last run:

21.11.2016 14:32:26.538 *ERROR* [CM Configuration Updater (ManagedServiceFactory Update: factoryPid=[org.apache.sling.commons.log.LogManager.factory.config])] org.apache.felix.configadmin Service [org.apache.felix.cm.ConfigurationAdmin,28, [org.osgi.service.cm.ConfigurationAdmin]] [org.osgi.service.cm.ManagedServiceFactory, id=19, bundle=8/slinginstall:org.apache.sling.commons.log-5.0.1-SNAPSHOT.jar]: Updating property org.apache.sling.commons.log.names of configuration org.apache.sling.commons.log.LogManager.factory.config.b4cf7982-9af0-40a1-b720-3e83a9f9e7f9 caused a problem: Category log.request already defined by configuration org.apache.sling.commons.log.LogManager.factory.config.b4cf7982-9af0-40a1-b720-3e83a9f9e7f9 (org.osgi.service.cm.ConfigurationException: org.apache.sling.commons.log.names : Category log.request already defined by configuration org.apache.sling.commons.log.LogManager.factory.config.b4cf7982-9af0-40a1-b720-3e83a9f9e7f9)
org.osgi.service.cm.ConfigurationException: org.apache.sling.commons.log.names : Category log.request already defined by configuration org.apache.sling.commons.log.LogManager.factory.config.b4cf7982-9af0-40a1-b720-3e83a9f9e7f9
	at org.apache.sling.commons.log.logback.internal.config.LoggerManagedServiceFactory.updated(LoggerManagedServiceFactory.java:36)
	at org.apache.felix.cm.impl.helper.ManagedServiceFactoryTracker.updated(ManagedServiceFactoryTracker.java:159)
	at org.apache.felix.cm.impl.helper.ManagedServiceFactoryTracker.provideConfiguration(ManagedServiceFactoryTracker.java:93)
	at org.apache.felix.cm.impl.ConfigurationManager$ManagedServiceFactoryUpdate.provide(ConfigurationManager.java:1611)
	at org.apache.felix.cm.impl.ConfigurationManager$ManagedServiceFactoryUpdate.run(ConfigurationManager.java:1554)
	at org.apache.felix.cm.impl.UpdateThread.run0(UpdateThread.java:141)
	at org.apache.felix.cm.impl.UpdateThread.run(UpdateThread.java:109)
	at java.lang.Thread.run(Thread.java:745)
Caused by: org.apache.sling.commons.log.logback.internal.config.ConfigurationException: 
	at org.apache.sling.commons.log.logback.internal.LogConfigManager.updateLoggerConfiguration(LogConfigManager.java:533)
	at org.apache.sling.commons.log.logback.internal.config.LoggerManagedServiceFactory.updated(LoggerManagedServiceFactory.java:34)
	... 7 common frames omitted

Issue Links

• blocks: SLING-5745 Provide a button to clear all registered entities and reinstall those
• is related to: SLING-5887 OSGi Installer: configuration factory instances and regular configuration instances differ in terms of overwrite behaviour
• is related to: SLING-6393 Sling installer can duplicate factory configurations on opposite node if configuration is changed on local cluster node
• relates to: SLING-7786 Use R7 configuration admin supporting named factory configurations