[SLING-5900] Improve create agents API handling of duplicate IDs

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Content Distribution Core 0.1.18
• Fix Version/s: Content Distribution Core 0.2.0
• Component/s: Content Distribution
• Assignee: Timothee Maret
• Reporter: Ana Vinatoru
• Created: 25/Jul/16 14:31
• Updated: 14/Feb/17 09:30
• Resolved: 04/Oct/16 06:32

Description

The distribution agent creation API has the wrong results in the following scenarios:

• Scenario 1:
  • create agent with id Bob and type Forward
  • create agent with id Bob and type Reverse
  • the first agent is now replaced by the second one. I think this should be an error case (i.e. if there's already an agent with the same ID and a different type, the API should return an error).

• Scenario 2
  • create agent with id Bob and type Forward
  • create agent with id Bob and type Forward
  • the properties of the first agent are overwritten by what we inputted at step 2

I am using the API from a create / update UI context, so one solution would be to add an ":operation" parameter to distinguish between the two cases.

So a "create" on an existing agent resource should fail, regardless of agent type, but an "update" should work.

Issue Links

• relates to: SLING-5872 Management of agent configurations must identify configurations by name