[SLING-5726] Allow ValueMapInjector and ResourcePathInjector to act directly on SlingHttpServletRequest

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Sling Models Impl 1.2.8
• Fix Version/s: Models Implementation 1.5.0
• Component/s: Extensions
• Assignee: Konrad Windszus
• Reporter: Konrad Windszus
• Created: 13/May/16 08:34
• Updated: 10/Dec/21 09:26
• Resolved: 03/Dec/21 16:05

Description

Currently both injectors only work correctly on objects being adaptable to a ValueMap. For ValueMapInjector this is documented but for ResourcePathInjector it is not (http://sling.apache.org/documentation/bundles/models.html#available-injectors), although for the latter it does only matter if the path is given through a resource property and not in a static way.

This should be relaxed that both also work with SlingHttpServletRequest as that always carries the current resource from which the ValueMap can be easily retrieved.

Issue Links

• is related to: SLING-9674 Allow SlingHttpServletRequest based adaptations for ChildResourceInjector
• is related to: SLING-8279 Having a Resource + ResourceMetadata should be sufficient for roundtrip link mapping.
• relates to: SLING-5721 Extend Sling Models to allow mapping of ValueMap values to custom types
• relates to: SLING-5590 Move Sling HTTP Servlet Request Adaptor Factory out of Validation Core