[SLING-5458] support discovery-lite's id==null (by managing the id in discovery.oak)

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Discovery Oak 1.2.0
• Fix Version/s: Discovery Commons 1.0.8, Discovery Oak 1.2.2
• Component/s: Extensions
• Assignee: Stefan Egli
• Reporter: Stefan Egli
• Created: 27/Jan/16 11:26
• Updated: 04/Feb/16 09:05
• Resolved: 27/Jan/16 16:16

Description

OAK-3672 describes the fact that the (cluster) id in tarMk case is not persisted and thus doesn't survive server restarts. This breaks the discovery API contract since discovery.oak uses this id directly as the ClusterView.getId - and that must by definition be stable (across restarts that is).

The solution suggested on oak-dev list is to have tarMk return null for this id (while mongoMk still manages this id).

This implies that discovery.oak must now handle the fact that the discovery-lite id is null. In which case it should readOrDefine a clusterId at /var/discovery/oak.

This will auto-support cold standby/failover as well as not harm the repo-clone case (as this solution is equivalent to how discovery.impl is working).

Issue Links

• blocks: OAK-3672 discovery-lite should not set (cluster)Id for tarMk and mongoMk (was: SegmentDiscoveryLiteService does not persist clusterView.id)
• breaks: SLING-5464 Regression in discovery's ViewStateManagerImpl.onlyDiffersInProperties