Uploaded image for project: 'Sling'
  1. Sling
  2. SLING-5231

Remove getAdministrativeResourceResolver() usage from Discovery components

Details

    Description

      • org.apache.sling.discovery.base: 6
      • org.apache.sling.discovery.commons: 3
      • org.apache.sling.discovery.oak: 4

      total of 13 occurrences

      Attachments

        1. base-patch.txt
          60 kB
          Carsten Ziegeler
        2. commons-patch.txt
          48 kB
          Carsten Ziegeler
        3. impl-patch.txt
          67 kB
          Carsten Ziegeler
        4. oak-patch.txt
          35 kB
          Carsten Ziegeler

        Issue Links

          Activity

            stefanegli Stefan Egli added a comment -

            there's also some in org.apache.sling.discovery.impl

            stefanegli Stefan Egli added a comment - there's also some in org.apache.sling.discovery.impl
            stefanegli Stefan Egli added a comment -

            moving one version out as this requires some synching within the entire teams

            stefanegli Stefan Egli added a comment - moving one version out as this requires some synching within the entire teams
            stefanegli Stefan Egli added a comment -

            the discovery use cases can be divided into two different types:

            1. read/write access to /var/discovery (configurable at the moment)
            2. read of descriptor (resolver.adaptTo(Session.class).getRepository().getDescriptor(..))

            regarding configurabililty of /var/discovery: in theory that could be set to just '/' at the moment - however, that's by no means a requirement and we could easily restrict this config to be always under /var for example.

            which means: for type 1. use cases this will probably result in a "/var service-user" - which might be shared between discovery (SLING-5231) and eventing (SLING-5232, SLING-5230)

            stefanegli Stefan Egli added a comment - the discovery use cases can be divided into two different types: read/write access to /var/discovery (configurable at the moment) read of descriptor ( resolver.adaptTo(Session.class).getRepository().getDescriptor(..) ) regarding configurabililty of /var/discovery : in theory that could be set to just '/' at the moment - however, that's by no means a requirement and we could easily restrict this config to be always under /var for example. which means: for type 1. use cases this will probably result in a "/var service-user" - which might be shared between discovery ( SLING-5231 ) and eventing ( SLING-5232 , SLING-5230 )

            Patch for discovery commons

            cziegeler Carsten Ziegeler added a comment - Patch for discovery commons

            Patch for discovery base

            cziegeler Carsten Ziegeler added a comment - Patch for discovery base

            It seems there are no special permissions required for 2.

            cziegeler Carsten Ziegeler added a comment - It seems there are no special permissions required for 2.

            Patch for discovery impl

            cziegeler Carsten Ziegeler added a comment - Patch for discovery impl

            Patch for discovery oak

            cziegeler Carsten Ziegeler added a comment - Patch for discovery oak

            I'Ve attatched separate patches for each module. Once SLING-5355 is resolved, we can apply them.
            As outlined above discovery needs a service user for read/write/delete at /var/discovery (default config)

            I think we should not share the user with other bundles, like job handling.

            cziegeler Carsten Ziegeler added a comment - I'Ve attatched separate patches for each module. Once SLING-5355 is resolved, we can apply them. As outlined above discovery needs a service user for read/write/delete at /var/discovery (default config) I think we should not share the user with other bundles, like job handling.
            stefanegli Stefan Egli added a comment -

            moved from discovery.oak 1.2.2 to 1.2.4 (to be able to release 1.2.2 early)

            stefanegli Stefan Egli added a comment - moved from discovery.oak 1.2.2 to 1.2.4 (to be able to release 1.2.2 early)
            stefanegli Stefan Egli added a comment -

            moved from discovery.commons 1.0.8 to 1.0.10 (in order to be able to release 1.0.8 early)

            stefanegli Stefan Egli added a comment - moved from discovery.commons 1.0.8 to 1.0.10 (in order to be able to release 1.0.8 early)
            stefanegli Stefan Egli added a comment -

            .. and another move to discovery.commons 1.0.12/discovery.oak 1.2.6

            stefanegli Stefan Egli added a comment - .. and another move to discovery.commons 1.0.12/discovery.oak 1.2.6
            stefanegli Stefan Egli added a comment -

            .. and another move to discovery.oak 1.2.8 (to get out SLING-5480)

            stefanegli Stefan Egli added a comment - .. and another move to discovery.oak 1.2.8 (to get out SLING-5480 )
            stefanegli Stefan Egli added a comment -

            Merged patches from cziegeler to the discovery bundles in http://svn.apache.org/viewvc?rev=1769802&view=rev and http://svn.apache.org/viewvc?rev=1769804&view=rev, thx for the patches Carsten!

            stefanegli Stefan Egli added a comment - Merged patches from cziegeler to the discovery bundles in http://svn.apache.org/viewvc?rev=1769802&view=rev and http://svn.apache.org/viewvc?rev=1769804&view=rev , thx for the patches Carsten!

            People

              stefanegli Stefan Egli
              asanso Antonio Sanso
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: