[SLING-5029] ModelFactory.canCreateFromAdaptable can report false positives

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Sling Models Impl 1.2.2
• Fix Version/s: Sling Models API 1.3.0, Sling Models Impl 1.2.6
• Component/s: Extensions
• Labels: models
• Assignee: Konrad Windszus
• Reporter: Konrad Windszus
• Created: 17/Sep/15 07:52
• Updated: 09/Sep/16 11:46
• Resolved: 08/Jan/16 17:27

Description

As being mentioned by [e-mail] in https://issues.apache.org/jira/browse/SLING-4997?focusedCommentId=14734059&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14734059 the method ModelFactory.canCreateFromAdaptable may return false positives in case the class has a model annotation but is still not registered due to last line in ModelFactory.getImplementationTypeForAdapterType(...).

In the best case an exception should be thrown if the class has a Model annotation but is still not registered (but probably that is not easily possible to detect in case of different adapter classes). Therefore at least the handling should be consistent here.