[SLING-4805] ResourceResolver should extend Closable interface.

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: API 2.9.0
• Fix Version/s: API 2.11.0
• Component/s: API
• Assignee: Carsten Ziegeler
• Reporter: Michał Chudy
• Created: 13/Jun/15 14:03
• Updated: 08/Feb/16 22:11
• Resolved: 13/Jun/15 15:31

Description

While creating ResourceResolver, we have to remember to close it and code looks like that:

ResourceResolver resourceResolver = null;
try {
	resourceResolver = resourceResolverFactory.getServiceResourceResolver(null);
} catch (LoginException e) {
	LOGGER.error("Error during getting instance of ResourceResolver class", e);
} finally {
	if (resourceResolver != null) {
		resourceResolver.close();
	}
}

While making ResourceResolver additionally extend Closable (or AutoClosable) interface, we could use try-with-resources Java 7 feature and our code would be more concise, elegant, readable.

try (ResourceResolver resolver = factory.getServiceResourceResolver(null)) {
	//do sth
}

(Please notice that Closable is still part of Java 6 API)

Issue Links

• is duplicated by: SLING-4798 ResourceResolver should extend java.io.Closeable