[SLING-4767] Optional sub models are logged as warn if they cannot be adapted

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: Sling Models API 1.2.0, Sling Models Impl 1.2.0
• Assignee: Konrad Windszus
• Reporter: Georg Henzler
• Created: 01/Jun/15 06:12
• Updated: 28/May/20 10:20
• Resolved: 03/Jun/15 07:26

Description

Currently Sling Models logs the example model [1] as warning [2] if the sub model image does not exist. This really should be a debug log as it is totally fine if in optional field cannot be set?

[1]

com......mediagallery.MediaGalleryElement
...
    @Inject
    @Optional
    @Named(value = ".")
    private Image image;

[2] org.apache.sling.models.impl.ModelAdapterFactory.injectElement(InjectableElement, Object, Model, DisposalCallbackRegistry, InjectCallback)

                // log previous injection error, if there was any
                if (lastInjectionException != null) {
                    log.warn("Although falling back to default value worked, injection into {} failed because of: " + lastInjectionException.getMessage(), element.getAnnotatedElement(), lastInjectionException);
                }

Issue Links

• breaks: SLING-5389 Sling Models: Do not swallow PostConstruct exceptions
• relates to: SLING-9478 Expose the full stack trace for PostConstruct exceptions