[SLING-3887] API: Un-deprecate ResourceUtil.getValueMap method

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: API 2.8.0
• Fix Version/s: API 2.9.0
• Component/s: API
• Assignee: Carsten Ziegeler
• Reporter: Stefan Seifert
• Created: 27/Aug/14 13:00
• Updated: 09/Mar/15 12:26
• Resolved: 10/Sep/14 07:53

Description

the method ResourceUtil.getValueMap(<Resource>) is deprecated since rev. 1577527 (in context of SLING-3453/SLING-3451) referring to Resource.getValueMap().

but these two methods are not fully equivalent from a convenience perspective: ResourceUtil.getValueMap supports returning an empty map if the resource is null, while for the Resource.getValueMap() an explicit null check and returning an empty map has to be implemented by the caller, which is too much boilerplate code.

the simplest solution would be to just undeprecate it. patch attached.

Issue Links

• relates to: SLING-988 [PATCH] ResourceUtil.getValueMap() causes NPE