Uploaded image for project: 'Sling'
  1. Sling
  2. SLING-3828

Hardcoded creation of SegmentNodeStoreService config makes it impossible to remove this configuration

Details

    Description

      The Activator in org.apache.sling.jcr.oak.server always creates a configuration item with PID org.apache.jackrabbit.oak.plugins.segment.SegmentNodeStoreService if it isn't there. This means that if you delete this configuration, it will reappear on restart.

      In some cases this configuration is undesirable, for example when running with Mongo. Therefore it should be possible to delete it.

      Attachments

        1. oak-server.diff
          6 kB
          David Bosschaert

        Activity

          The attached patch replaces the config generation in the Activator with a configuration provided via the launchpad. The configuration will still appear by default, but when deleted it will not reappear on restart.

          bosschaert David Bosschaert added a comment - The attached patch replaces the config generation in the Activator with a configuration provided via the launchpad. The configuration will still appear by default, but when deleted it will not reappear on restart.

          Thanks for your patch, David. It's applied with rev 1616461
          I've also fixed the it test for oak which now requires to setup the segment store configuration

          cziegeler Carsten Ziegeler added a comment - Thanks for your patch, David. It's applied with rev 1616461 I've also fixed the it test for oak which now requires to setup the segment store configuration
          sseifert Stefan Seifert added a comment - - edited

          in this rev. these lines from launchpad/builder/pom.xml were removed:

                  <!-- trick maven-launchpad-plugin into not copying any configs -->
                  <empty.config.directory>${project.build.directory}/NOCONFIGS</empty.config.directory>
          

          why? because of this on every build an empty directory named (literally)

          ${empty.config.directory}

          is created.

          the line was added by bertrand in context of SLING-3155 (rev. Revision: 1533101). if it is no longer required the corresponding maven-antrun-plugin should be removed as well.

          sseifert Stefan Seifert added a comment - - edited in this rev. these lines from launchpad/builder/pom.xml were removed: <!-- trick maven-launchpad-plugin into not copying any configs --> <empty.config.directory> ${project.build.directory}/NOCONFIGS </empty.config.directory> why? because of this on every build an empty directory named (literally) ${empty.config.directory} is created. the line was added by bertrand in context of SLING-3155 (rev. Revision: 1533101). if it is no longer required the corresponding maven-antrun-plugin should be removed as well.

          The reason is we now have configurations, and I don't see this empty dir anymore in my recent build

          cziegeler Carsten Ziegeler added a comment - The reason is we now have configurations, and I don't see this empty dir anymore in my recent build
          sseifert Stefan Seifert added a comment -

          it's still configured in the pom in trunk, referencing twice the (now) invalid property empty.config.directory.
          in rev. 1623739 i've removed these references - on my machine launchpad is running fine.

          please cross-check.

          sseifert Stefan Seifert added a comment - it's still configured in the pom in trunk, referencing twice the (now) invalid property empty.config.directory . in rev. 1623739 i've removed these references - on my machine launchpad is running fine. please cross-check.

          Oh right, thanks for fixing this - it seems I made the change locally but never committed...

          cziegeler Carsten Ziegeler added a comment - Oh right, thanks for fixing this - it seems I made the change locally but never committed...

          People

            cziegeler Carsten Ziegeler
            bosschaert David Bosschaert
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: