[SLING-3498] Don't log stacktrace on IOException

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Engine 2.3.2
• Fix Version/s: Engine 2.3.4
• Component/s: Engine
• Assignee: Felix Meschberger
• Reporter: Felix Meschberger
• Created: 08/Apr/14 14:49
• Updated: 03/Aug/15 11:41
• Resolved: 10/Apr/14 18:49

Description

The SlingMainServlet logs IOExceptions depending on the actual cause:

} catch (IOException ioe) {
    // unwrap any causes (Jetty wraps SocketException in
    // EofException)
    Throwable cause = ioe;
    while (cause.getCause() != null) {
        cause = cause.getCause();
    }
    if (cause instanceof SocketException) {
        // if the cause is a SocketException, the client most
        // probably
        // aborted the request, we do not fill the log with errors
        // in this case
        log.debug(
            "service: Socketexception (Client abort or network problem",
            ioe);
    } else {
        // otherwise we want to know why the servlet failed
        log.error(
            "service: Uncaught IO Problem while handling the request",
            ioe);
    }
} ...

The idea is to try to find out, whether the IOException is caused by the client aborting the request or some other problem.

NIO socket channels, though, don't throw SocketException but just IOException in this case, so this above code will always log an ERROR message with a stack trace. This message has no real use and we should change this and log the IOException as an INFO message (if at all) and at most dump the stack trace as a DEBUG message.

Issue Links

• relates to: SLING-4921 SlingMainServlet logs IOException at debug level only