[SLING-3342] Do not use SlingBindings in Java code

• Type: Task
• Status: Resolved
• Priority: Minor
• Resolution: Won't Fix
• Component/s: Best practices
• Assignee: Unassigned
• Reporter: Bertrand Delacretaz
• Created: 28/Jan/14 11:13
• Updated: 04/May/23 09:25
• Resolved: 04/May/23 09:25

Description

*DRAFT* - to be reviewed, and we need to update the SlingBindings javadocs as well.

SlingBindings is meant to be used in Sling scripts.

It might be available as a Request attribute in some cases, as Sling sets that before running scripts, but one cannot rely on that in java code.

There’s usually no reason to use it in Java code anyway, all the services that it provides are available directly, for example via an @Reference annotation.

Here’s a typical counter-example which should use an @Reference to the FooBar service instead:

// Do NOT do that!
SlingBindings bindings = (SlingBindings)request.getAttribute(SlingBindings.class.getName());
SlingScriptHelper scriptHelper = bindings.getSling();
FooBar fb = scriptHelper.getService(FoorBar.class);